Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose properties for executing this plugin from command line without specify plugin configuration in pom.xml #596

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cloorc
Copy link

@cloorc cloorc commented Sep 2, 2022

Context

We need to execute this plugin with goal revision without specify this plugin in an existing maven project. We can do this by specifying parameters from command line. And this commit is going to expose these parameters to command line is enough.

Contributor Checklist

  • 🆗 Added relevant integration or unit tests to verify the changes
  • 🆗 Update the Readme or any other documentation (including relevant Javadoc)
  • 🆗 Ensured that tests pass locally: mvn clean package
  • 🆗 Ensured that the code meets the current checkstyle coding style definition: mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -B

@TheSnoozer
Copy link
Collaborator

Hello,
thanks for your contribution!
I remember that we had issues with those properties / settings and maven.
Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment)
I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

@cloorc
Copy link
Author

cloorc commented Sep 7, 2022

Hello, thanks for your contribution! I remember that we had issues with those properties / settings and maven. Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment) I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Yes, it seems like a but of Apache Maven itself. The hard-coded skip won't be overrided by command line options. But properties will. Such as :

<properties>
  <xxx.skip>false</xxx.skip>
</properties>
......
<skip>${xxx.skip}</skip>

@cloorc
Copy link
Author

cloorc commented Sep 20, 2022

Hello,
thanks for your contribution!
I remember that we had issues with those properties / settings and maven.
Effectively the command-line didn't overwrite anything that was encoded in the pom.xml.

For further details see #315 (comment)
I'd need to test if this somehow suffers similar problems. I'm honestly a bit sceptical...

Hi, could we just leave the maven defection to maven itself? And this feature could be useful without predefined configuration anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants