Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebookv2 #97

Merged
merged 14 commits into from
Jun 30, 2022
Merged

Notebookv2 #97

merged 14 commits into from
Jun 30, 2022

Conversation

nberkouk
Copy link
Collaborator

@nberkouk nberkouk commented Jun 29, 2022

Reference issues/PRs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Screenshots (if appropriate)

Any other comments?

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


nberkouk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@matteocao matteocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nberkouk for this PR! There are only very small changes needed: force-adding 2 images, fixing a couple of typos and adding a conclusion section (you will find the details on the comments on the Code lines)

Also, please remove tensorflow from the imports of the notebook: tensorboard workshop without it!

@matteocao matteocao linked an issue Jun 29, 2022 that may be closed by this pull request
Copy link
Contributor

@matteocao matteocao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked the CLA and you have been registered. Hence approving and merging.

@matteocao matteocao merged commit 90c0b89 into master Jun 30, 2022
@matteocao matteocao deleted the notebookv2 branch June 30, 2022 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a notebook reproducing topological study of entangled tori
3 participants