Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NB for BERT models #114

Merged
merged 13 commits into from
Oct 4, 2022
Merged

Add NB for BERT models #114

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8521e5b
add support and demo for huggingface BERT
hkirvesl Sep 29, 2022
c5489e7
add support and demo for huggingface BERT
hkirvesl Sep 29, 2022
412c142
clean BERT tutorial
hkirvesl Sep 29, 2022
2b09c8c
Merge branch 'giotto-ai:master' into hkdev
hkirvesl Sep 29, 2022
fa1b481
fix jupyter nb metadata
hkirvesl Sep 29, 2022
8fbbe57
Merge branch 'hkdev' of https://github.com/hkirvesl/giotto-deep into …
hkirvesl Sep 29, 2022
f70f562
fix data loading to pass the CI
hkirvesl Sep 29, 2022
3a39246
change pathdef to use os.path.join
hkirvesl Sep 29, 2022
c799be1
use os.path.join
hkirvesl Sep 29, 2022
86962b5
fix ModelExtractor BERT support
hkirvesl Sep 30, 2022
8120be9
merge recent fixes to main branch, eg precommits
hkirvesl Oct 1, 2022
55b510c
add fixes from black precommit hook
hkirvesl Oct 1, 2022
988d172
Clean up BERT notebook
hkirvesl Oct 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ repos:
- id: trailing-whitespace
- id: check-yaml
- id: check-added-large-files
- repo: https://github.com/psf/black
rev: 22.6.0
hooks:
- id: black
- repo: https://github.com/pre-commit/mirrors-mypy
rev: 'v0.971' # Use the sha / tag you want to point at
hooks:
- id: mypy
#- repo: https://github.com/psf/black
# rev: 22.8.0
# hooks:
# - id: black
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understood from raphael that mypy is causing issues, however black should not: it should simply frmat the code properly: why are you commenting black out?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please keep the hook for black.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please wait until my pull request is accepted and then pull again from master? I fixed all mypy errors, and the pre-commit does work now.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments, Matteo and Raphael. I did recall some discussion about problems with the prehooks and commenting them out being the recommended temporary work around. I just forgot the details and ended up commenting out too much. All these should be fixed now. Thank you Raphael for the fix, this makes our lives much easier.

#- repo: https://github.com/pre-commit/mirrors-mypy
# rev: 'v0.981' # Use the sha / tag you want to point at
# hooks:
# - id: mypy
Loading