Fix some issues with update with library #108
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhofer
force-pushed
the
update-with-library-fixes
branch
from
d3c9ff0 to
55ddf29
Compare
dkhofer
commented
Dec 9, 2024
|
|
||
| BlockGroup::prune_graph(&mut graph); | ||
| let (graph, _edges_by_node_pair) = Edge::build_graph(&edges, &blocks); | ||
| // BlockGroup::prune_graph(&mut graph); |
There was a problem hiding this comment.
This was causing problems because all the edges are currently getting a chromosome index of 0 when we update with a library, so most edges were getting pruned. I'm going to work on the real solution next
dkhofer
commented
Dec 10, 2024
| conn, | ||
| part_hash, | ||
| calculate_hash(&format!( | ||
| "{path_id}:{ref_start}-{ref_end}->{sequence_hash}-column-{index}", |
There was a problem hiding this comment.
Note that I needed to append column-{index} to the end of the hashed string in order to ensure a new node is created for a redundant part that's in a different column
dkhofer
force-pushed
the
update-with-library-fixes
branch
from
9c9ee9c to
1d152ce
Compare
dkhofer
force-pushed
the
update-with-library-fixes
branch
from
1d152ce to
57fdc04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.