fix: skip chmod on existing directories in SaveUploadedFile#4631
Open
Herrtian wants to merge 1 commit intogin-gonic:masterfrom
Open
fix: skip chmod on existing directories in SaveUploadedFile#4631Herrtian wants to merge 1 commit intogin-gonic:masterfrom
Herrtian wants to merge 1 commit intogin-gonic:masterfrom
Conversation
SaveUploadedFile called os.Chmod on the target directory even if it already existed. This breaks when saving to system directories like /tmp where the process lacks permission to chmod. Now only newly created directories get chmod'd. Existing directories are left as-is, which is the correct behavior since the caller should not modify permissions of directories they don't own. Fixes gin-gonic#4622
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4631 +/- ##
==========================================
- Coverage 99.21% 98.37% -0.84%
==========================================
Files 42 48 +6
Lines 3182 3143 -39
==========================================
- Hits 3157 3092 -65
- Misses 17 42 +25
- Partials 8 9 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4622
SaveUploadedFilecalledos.Chmodon the target directory unconditionally, even if it already existed. This broke file uploads to system directories like/tmp:Change
Added a check before calling
os.Chmod: only newly created directories get their permissions set. Pre-existing directories are left untouched.Updated
TestSaveUploadedFileWithPermissionto verify permissions on a newly created subdirectory rather than the current working directory. Added a Windows skip for the permission assertion since Windows doesn't support Unix file permissions.Test plan
go build ./...passesTestSaveUploadedFileWithPermissionpassesTestSaveUploadedFileWithPermissionFailedpassesTestFileDescriptorfailure is pre-existing (fails on master too on Windows)