Changed trailing slash redirection behaviour #4499
Open
+35
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now setting RedirectTrailingSlash to false will result in treating /foo and /foo/ as the same endpoints and won't cause redirection, they will share common handlers instead.
The current implementation is inefficient because I trigger second search if first failed, but I didn't figure out how to pass this information to findCaseInsensitivePathRec without breaking everything (and didn't know would it be right, how do you think?). Also, I would like to replace RedirectTrailingSlash with some TrailingSlashBehaviour enum, but it will break backward compatibility.
This pull request is meant to solve #4411
Would like to receive critics :)