fix(context): Allow Context.Value to properly support any key type #4492
+6
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix an inconsistency in the Context.Value method where it accepted keys of any type in its signature but internally restricted them to strings when pass to Context.Get.
Motivation
The Context.Value method had a signature accepting any for keys, but its implementation only worked with string keys due to a type assertion when pass to Context.Get. This was inconsistent with Context.Set which properly support any comparable key type. I using custom types as context keys (a common Go pattern to avoid key collisions) would find that Value didn't work while Set did.
Changes
Pull Request Checklist
Please ensure your pull request meets the following requirements:
masterbranch.docs/doc.md.