Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive dataset page #2211

Draft
wants to merge 24 commits into
base: develop
Choose a base branch
from
Draft

Responsive dataset page #2211

wants to merge 24 commits into from

Conversation

luistoptal
Copy link
Collaborator

Pull request for issue: #2189

IMPORTANT: merge first PR #2210

Responsive dataset page
image
image
image
image

How have functionalities been implemented?

  • Saw fitting to add a breakpoints.less file to avoid hardcoding breakpoint values in so many places. Took the chance to use the variables in all the appropriate places. The breakpoints file follows the same pattern as Bootstrap 3 responsiveness

Any issues with implementation?

--

Any changes to automated tests?

--

@luistoptal
feat: responsive top bar
47b81b3
@luistoptal
feat: display burger menu instead of broken nav
c62fffa
@luistoptal
feat: fix and style mobile nav
ed1c2a5
@luistoptal
feat: add focus trap to mobile navbar
64fa6ad
@luistoptal
feat: space header elements on mobile to avoid overlapping with hypot…
f4b0b49 
…hes widget
@luistoptal
feat: revamp footer styles to more easily add responsiveness
0281409
@luistoptal
feat: optimize footer text color, focus and hover interactions
a2c5b9f
@luistoptal
feat: update style guide with new footer
0dc19ea
@luistoptal
feat: responsive topbar
d22f50d
@luistoptal
feat: adds logo to mobile menu to avoid losing branding
d3131e4
@luistoptal
feat: responsive account menu
62718bb
@luistoptal
chore: up log
cc757d4
@luistoptal
feat: improve topbar look in small screens
9c94023
@luistoptal
feat: responsive datasettypes and rss sections
eabc76d
@luistoptal
feat: responsive rss panel
045cc10
@luistoptal
feat: responsive metrics section
0d57b3c
@luistoptal
feat: responsive hero
506c6df
@luistoptal
chroe: up changelog
88a90c4
@luistoptal
feat: responsive dataset media panel
7d8fd83
@luistoptal
feat: prevent modal overlap with hypotheses on mobile
aab4786
@luistoptal
feat: replace all hard coded media query values by variables
352796b
@luistoptal
feat: responsive table footer
884dc76
@luistoptal
chore: update log
c12c640
@luistoptal
fix: dataset type long label wrap
4943862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kencho51 kencho51 Awaiting requested review from kencho51 kencho51 will be requested when the pull request is marked ready for review kencho51 is a code owner

@pli888 pli888 Awaiting requested review from pli888 pli888 will be requested when the pull request is marked ready for review pli888 is a code owner

@rija rija Awaiting requested review from rija rija will be requested when the pull request is marked ready for review rija is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@luistoptal