webhooks: add acceptable error handling #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Monalisten task is not handled by discord.py, any exception that happens in there is dropped. There were several cases already where the bot stopped the webhook feed with no reported error on Sentry. This fixes that. The
reraise_with_payload
ctx manager is not ideal and is something I'd like to be part of Monalisten (which currently only handles errors related to the received event).