Spelling #2547
Merged
Spelling #2547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Feb 12, 2025
| @@ -14,5 +14,5 @@ npx @apollo/federation-subgraph-compatibility docker --compose apollo-compatibil | |||
| ### Printing the GraphQL Schema (SDL) | |||
|
|
|||
| ``` | |||
| sbt "apollo-compability/run printSchema" | |||
| sbt "apollo-compatibility/run printSchema" | |||
Comment on lines
-27
to
-28
| mapbeAllIDs: [ID!] @newtype(name: "MaybeInnerId") | ||
| mapbeAllIDsOpt: [ID] @newtype(name: "MaybeInnerIdOpt") |
docs/about/index.html
Outdated
| @@ -21,7 +21,7 @@ | |||
| </a></div><div class="nav-item"><a href="/caliban/about/" aria-current="page" class="nav-link router-link-exact-active router-link-active"> | |||
| About | |||
| </a></div><div class="nav-item"><a href="https://github.com/ghostdogpr/caliban" target="_blank" rel="noopener noreferrer" class="nav-link external"> | |||
| Github | |||
| GitHub | |||
There was a problem hiding this comment.
I'm happy to drop any particular change.
Afaict, this is all just the literal GitHub as opposed to a class or anything exciting (unlike GitLab where Gitlab appeared once in a class-ish thing...)
| @@ -232,7 +232,7 @@ object TapirAdapterSpec { | |||
| test("Returns 400 status code on validation errors") { | |||
| def test_(method: String) = | |||
| for { | |||
| resp <- runHttpRequest(method, acceptHeader, query = "{characterss { name }}") | |||
| resp <- runHttpRequest(method, acceptHeader, query = "{characters_ { name }}") | |||
There was a problem hiding this comment.
I'm assuming this is just trying to validate for something other than characters and I find using a _ is sufficient proof of that, while allowing a spell checker to identify other real typos...
| @@ -298,24 +298,24 @@ object SchemaWriter { | |||
| |}""".stripMargin | |||
| } | |||
|
|
|||
| def replaceNameOfInnertype(name: String, ftype: Type): Type = | |||
| def replaceNameOfInnerType(name: String, ftype: Type): Type = | |||
There was a problem hiding this comment.
It's possible Innertype is a reserved concept, but I'm hoping it's just Inner+Type
| @@ -120,7 +120,7 @@ object RemoteQuerySpec extends ZIOSpecDefault { | |||
| actual == """query{union(value:"{\"foo\": \"\\n\"}"){...on Interface{id}}}""" | |||
| ) | |||
| }, | |||
| test("correctly renders a query for a field of json escaped escaped quote") { | |||
| test("correctly renders a query for a field of json double escaped quote") { | |||
There was a problem hiding this comment.
It's really hard to tell if this is intentionally doubled or accidentally, using the word double instead makes it clear...
| @@ -29,7 +29,7 @@ These interpreters expose 2 powerful methods: | |||
| - `configure` takes a `Configurator[R]` which is an alias for `URIO[R & Scope, Unit]`. | |||
| It allows configuring the interpreter by running an effect that will run for each request and that can modify the configuration of the running fiber. Built-in configurators such as `Configurator.setSkipValidation`, `Configurator.setEnableIntrospection` and `Configurator.setQueryExecution` let you dynamically change the configuration of the interpreter. | |||
| - `intercept` takes an `Interceptor[-R1, +R]` which is an alias for `ZLayer[R1 & ServerRequest, TapirResponse, R]`. | |||
| It is basically a more powerful version of `configure` that gives you access to the incoming request (`ServerRequest`) and lets you modify the environment of the interpreter (from `R` to `R1`). A typical use case would be to extract an authentication token from the request and eliminate the authentication requirement from the environment if the token is valid. See an example [here](https://github.com/ghostdogpr/caliban/blob/series/2.x/examples/src/main/scala/example/akkahttp/AuthExampleApp.scala#L51). | |||
| It is basically a more powerful version of `configure` that gives you access to the incoming request (`ServerRequest`) and lets you modify the environment of the interpreter (from `R` to `R1`). A typical use case would be to extract an authentication token from the request and eliminate the authentication requirement from the environment if the token is valid. See an example route [`HttpInterpreter(...)...intercept(...)`](https://github.com/ghostdogpr/caliban/blame/58b459bd7fb2ca0b20fc62226aa1afc4edefa26d/examples/src/main/scala/example/akkahttp/AuthExampleApp.scala#L51). | |||
There was a problem hiding this comment.
- I didn't mean to change
blobtoblame, but ... - using a tag instead of a commit means that lines drift, the current line 51 is:
- using
[here]is hostile to accessibility agents, so I've tried to provide a link text that's helpful:
Do not use (click) here links
For more information, see:
- https://www.w3.org/QA/Tips/noClickHere
- https://webaim.org/techniques/hypertext/link_text
- https://granicus.com/blog/why-click-here-links-are-bad/
- https://heyoka.medium.com/dont-use-click-here-f32f445d1021
(?i)(?:>|\[)(?:(?:click |)here|link|(?:read |)more)(?:</|\]\()
| @@ -119,7 +119,7 @@ by using `caliban.federation.v2_x` where `x` is the minor version of the specifi | |||
| | Directive | Caliban Type | Version | Caliban package | |||
| --------------| --------------|---------| --------------- | |||
| | `@shareable` | `@GQLShareable` | v2.0 | `caliban.federation.v2_0` | |||
| | `@inaccessable` | `@GQLInaccessible` | v2.0 | `caliban.federation.v2_0` | |||
| | `@inaccessible` | `@GQLInaccessible` | v2.0 | `caliban.federation.v2_0` | |||
There was a problem hiding this comment.
notable. I hope this is correct, it's pretty odd to have this spelling...
ghostdogpr
reviewed
Feb 12, 2025
Signed-off-by: Josh Soref <[email protected]>
jsoref
commented
Feb 12, 2025
| @@ -36,7 +36,7 @@ module.exports = { | |||
| link: '/about/' | |||
| }, | |||
| { | |||
| text: 'Github', | |||
| text: 'GitHub', | |||
There was a problem hiding this comment.
This line was the thing that was updating the other .html files, but I've dropped the changes to the html files...
ghostdogpr
reviewed
Feb 13, 2025
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects misspellings identified by the check-spelling action
The misspellings have been reported at https://github.com/jsoref/caliban/actions/runs/13278582458#summary-37072536513
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/caliban/actions/runs/13278582569#summary-37072536820