Add unminified version and fix #153 bug in validation service

ghiscoding · Apr 20, 2017 · 61e0238 · 61e0238
1 parent d253eab
commit 61e0238
Show file tree

Hide file tree

Showing 7 changed files with 3,369 additions and 7 deletions.
diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-validation-ghiscoding",
-  "version": "1.5.19",
+  "version": "1.5.20",
   "author": "Ghislain B.",
   "description": "Angular-Validation Directive and Service (ghiscoding)",
   "main": [

diff --git a/dist/angular-validation.js b/dist/angular-validation.js
diff --git a/dist/angular-validation.min.js b/dist/angular-validation.min.js
diff --git a/gulpfile.js b/gulpfile.js
@@ -88,6 +88,18 @@ gulp.task('compress', ['clean'], function() {
     .pipe(gulp.dest('./'));
   }
 
+  // compress (src/*.js) into 1 single minified file
+  gulp.src(src + '*.js')
+    .pipe(order([
+      'validation-directive.js',
+      'validation-common.js',
+      'validation-rules.js',
+      'validation-service.js'
+      ]))
+    .pipe(concat('angular-validation.js'))
+    .pipe(header(jsHeaderComment, { pkg : pkg, version: newVersion } ))
+    .pipe(gulp.dest('dist'));
+
   // compress (src/*.js) into 1 single minified file
   gulp.src(src + '*.js')
     .pipe(order([

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "angular-validation-ghiscoding",
-  "version": "1.5.19",
+  "version": "1.5.20",
   "author": "Ghislain B.",
   "description": "Angular-Validation Directive and Service (ghiscoding)",
   "main": "dist/angular-validation.min",

diff --git a/readme.md b/readme.md
@@ -1,5 +1,5 @@
 # Angular Validation (Directive / Service)
-`Version: 1.5.19`
+`Version: 1.5.20`
 ### Forms Validation with Angular made easy!
 ##### (Concept comes from the amazing Laravel)
 

diff --git a/src/validation-service.js b/src/validation-service.js
@@ -98,7 +98,7 @@ angular
 
       // Possible element attributes
       _validationCallback = (self.validationAttrs.hasOwnProperty('validationCallback')) ? self.validationAttrs.validationCallback : null;
-      _validateOnEmpty = (self.validationAttrs.hasOwnProperty('validateOnEmpty')) ? commonObj.parseBool(self.validationAttrs.validateOnEmpty) : !!_globalOptions.validateOnEmpty;
+      _validateOnEmpty = (self.validationAttrs.hasOwnProperty('validateOnEmpty')) ? self.commonObj.parseBool(self.validationAttrs.validateOnEmpty) : !!_globalOptions.validateOnEmpty;
 
       // onBlur make validation without waiting
       attrs.elm.bind('blur', _blurHandler = function(event) {