Skip to content

Conversation

@jeffbolznv
Copy link
Collaborator

msbuild performance has been poor recently, particularly since the model implementations were split into separate source files. This change enables MultiToolTask which enables parallelism within a project without the problems of /MP. See https://devblogs.microsoft.com/cppblog/improved-parallelism-in-msbuild/.

I tested each of the vulkan and cuda backends. My CPU is a 32-core threadripper.

vulkan before
========== Rebuild started at 2:50 PM and took 03:38.550 minutes ==========
vulkan after
========== Rebuild started at 3:36 PM and took 01:57.272 minutes ==========

cuda before
========== Rebuild started at 3:27 PM and took 07:59.340 minutes ==========
cuda after
========== Rebuild started at 3:38 PM and took 06:17.516 minutes ==========

This is supported in vs2019+. I think unknown options are ignored, so this shouldn't be harmful on older versions.

Copy link
Member

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have an environment to test this. Feel free to merge if it works on your end.

@Acly
Copy link
Collaborator

Acly commented Dec 3, 2025

Maybe guard it with if(LLAMA_STANDALONE) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Compilation issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants