Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add install-docker.sh #1

Merged
merged 3 commits into from Mar 25, 2024
Merged

ci: add install-docker.sh #1

merged 3 commits into from Mar 25, 2024

Conversation

phymbert
Copy link
Contributor

Motivation

Docker is a best practice to ensure reproducibility and isolation.

This small script to install docker with nvidia capability properly on a fresh VMs after setup.sh, install-cuda.sh.

In the context of ggerganov/llama.cpp#6233

@phymbert phymbert marked this pull request as draft March 22, 2024 19:55
@phymbert phymbert marked this pull request as ready for review March 24, 2024 14:04
@phymbert
Copy link
Contributor Author

@ggerganov @ngxson FYI

@ngxson
Copy link
Contributor

ngxson commented Mar 24, 2024

There's a trick to install docker that not many people know about: you can wget or curl the official install script from https://get.docker.com . This script works on any linux distro, not just ubuntu.

Personally I use this one-liner command: curl -fsSL get.docker.com | bash

This replaces the part in your script where it adds apt repo and does apt install. The rootless part and nvidia driver part is however not included, so let's keep it.

Also do we have a reason not to run docker in root-full mode? (Assuming that the machine is cleaned up every time we run it). AFAIK, rootless mode sometimes have less privilege and in some cases use less-performant fs driver. Personally I only use rootless if it's a nested docker-in-docker (dind)

@phymbert
Copy link
Contributor Author

The script is used in the child image yes. For the VM, I prefer to go the hard way.
See the next PR, we do docker in docker

@phymbert
Copy link
Contributor Author

@ggerganov I do not have write access B-)

@ggerganov
Copy link
Member

Invite sent

@phymbert phymbert merged commit 9bcfeb6 into ggml-org:master Mar 25, 2024
@phymbert phymbert deleted the hp/docker branch March 25, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants