Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node : fix compilation #2115

Merged
merged 3 commits into from May 2, 2024
Merged

node : fix compilation #2115

merged 3 commits into from May 2, 2024

Conversation

pprobst
Copy link
Contributor

@pprobst pprobst commented May 1, 2024

This PR fixes the addon.node compilation and updates index.js, along with the README, to conform with:

set_target_properties(addon.node PROPERTIES FOLDER "examples")

See issues #2085, #2091.

@valVk
Copy link
Contributor

valVk commented May 2, 2024

Hi.
Try to update this line and I believe all checks became green.

https://github.com/ggerganov/whisper.cpp/blob/master/.github/workflows/examples.yml#L40

@bobqianic bobqianic merged commit 58210d6 into ggerganov:master May 2, 2024
51 checks passed
viktor-silakov pushed a commit to viktor-silakov/whisper_node_mic.cpp that referenced this pull request May 11, 2024
* node : fix compilation and update examples

* node : fix readme

* Update addon.node test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants