Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : add building in MSYS2 environments (Windows) #1994

Merged
merged 1 commit into from Mar 30, 2024

Conversation

przemoc
Copy link
Contributor

@przemoc przemoc commented Mar 26, 2024

Implements #1780.


It will be failing until #1778 will get merged and this PR rebased then.

@przemoc
Copy link
Contributor Author

przemoc commented Mar 26, 2024

Proof that it is passing on top of the other PR (+ disabled other jobs to speed up testing):
https://github.com/przemoc/whisper.cpp/commits/2de03c28f9b19493e18d021724610f97b38d2c22
https://github.com/przemoc/whisper.cpp/actions/runs/8429013889

@ulatekh
Copy link
Contributor

ulatekh commented Mar 27, 2024

I made a MinGW build in the process of looking at this project...CUDA isn't supported under MinGW, so there seems to be little point.

@przemoc
Copy link
Contributor Author

przemoc commented Mar 29, 2024

Rebased and resolved very minor whitespace merge conflict.

@ulatekh, I think whisper.cpp started without any CUDA support at the beginning, so just because CUDA is not supported under MinGW-w64 doesn't mean it's not worth to have checks to ensure building in MSYS2 environments remains functional.

@przemoc
Copy link
Contributor Author

przemoc commented Mar 29, 2024

After merging #1778, rebased one final time and, as expected, all is green now.

@ggerganov ggerganov merged commit ac283db into ggerganov:master Mar 30, 2024
49 checks passed
@przemoc przemoc deleted the add-msys2-build-job branch April 12, 2024 16:28
jiahansu pushed a commit to OOPRY/whisper.cpp that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants