New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
whisper : allocate encoder results in dedicated buffer #1964
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the
wstate.embd_conv
now pre-allocated, this view still triggers the assert:Not sure why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code that stores the allocation location of leafs didn't take into account pre-allocated leafs. This should fix it:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With just this change applied on
master
the code also works (i.e. without pre-allocating the tensors). But if I understand correctly, it is technically not correct because nothing guarantees that the data in these tensors would not be overwritten by some ops. Since they are currently at the end of the computation graphs it seems to produce correct results, but the concern is that this is not very future-proof if we expand the graphs in the future - is that correct?What if I use
ggml_set_output(ctx0, wstate.embd_conv);
inwhisper_build_graph_conv()
to guarantee that the data would not be overwritten?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, with
ggml_set_output
it would guarantee that the tensor is never overwritten.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would pre-allocating the tensors as proposed in this PR have any advantage over the
ggml_set_output
option? Since with this PR we now have to perform extra copy of the data between the graph calls, which otherwise is not needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there would be any significant advantage. Maybe it would allow using
ggml_gallocr_reserve
here instead ofggml_gallocr_alloc_graph
, but the difference would be minimal:whisper.cpp/whisper.cpp
Lines 496 to 502 in 66df44b