Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main : add --conversation / -cnv flag #7108

Merged
merged 1 commit into from
May 8, 2024

Conversation

dawidpotocki
Copy link
Contributor

@dawidpotocki dawidpotocki commented May 6, 2024

Closes #7100

This flag enables interactive mode and disables printing special tokens and suffix/prefix.
The name for the flag is not great, but couldn't think of anything good.

People in the issue seemed to be interested in something like this.

Example output:

> Hello!
Hello! It's nice to meet you. Is there something I can help you with, or would you like to chat?

> Nah, I'm good.
No worries then! It's always okay to just chill and say hi.

>

Potentially special token printing should also be disabled for --chatml and --instruct.

@Jeximo
Copy link
Contributor

Jeximo commented May 7, 2024

This is a nice feature. Reduces the clutter when chatting with Llama3.

@mirek190
Copy link

mirek190 commented May 8, 2024

thanks

@ggerganov ggerganov merged commit 83330d8 into ggerganov:master May 8, 2024
52 of 57 checks passed
@olinorwell
Copy link

olinorwell commented May 9, 2024

I feel like this flag should not enable interactive mode. That already has it's own flag.

All it should do is what the original request wanted it to do, which was effectively "disables printing special tokens and suffix/prefix".

The interactive mode being enabled is a result of the use case it fell into, not the requested feature.

Appreciate the effort but I believe it should be called something like 'no special token output' and do what it was originally doing, which was only outputting generated tokens that were not considered 'special', thus no <|eot_id|> at the end for example.

The flag could then be used in any of the modes as and when it was required.

@mofosyne mofosyne added enhancement New feature or request review complexity : low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix labels May 9, 2024
@dawidpotocki dawidpotocki deleted the conversation branch May 9, 2024 22:40
@dawidpotocki
Copy link
Contributor Author

Welp, that's fair.

I guess such flag could still be added as I don't think changing the
behaviour of this one would make much sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review complexity : low Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is possible to hide start / stop tokens?
6 participants