Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ggml : designate enum vals for integer types #6050

Merged
merged 1 commit into from Mar 14, 2024
Merged

ggml : designate enum vals for integer types #6050

merged 1 commit into from Mar 14, 2024

Conversation

ggerganov
Copy link
Owner

Set the enum values for:

        GGML_TYPE_I8      = 24,
        GGML_TYPE_I16     = 25,
        GGML_TYPE_I32     = 26,

This avoids breaking models that store integer tensors when adding new quantization types in the future. It's too late to move them at the start of the enum as this will break all existing models

@ggerganov ggerganov mentioned this pull request Mar 14, 2024
Merged
@ggerganov ggerganov merged commit 3fe8d7a into master Mar 14, 2024
53 of 63 checks passed
@ggerganov ggerganov deleted the gg/ggml-type-vals branch March 14, 2024 10:38
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 15, 2024
@ggerganov @NeoZhangJianyu
ggml : designate enum vals for integer types (ggerganov#6050)
58fd227
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
@ggerganov @hodlen
ggml : designate enum vals for integer types (ggerganov#6050)
2f128f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ggerganov