Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llama : more consistent names of count variables #5994

Merged
merged 4 commits into from Mar 11, 2024
Merged

llama : more consistent names of count variables #5994

merged 4 commits into from Mar 11, 2024

Conversation

ggerganov
Copy link
Owner

No description provided.

@slaren
Copy link
Collaborator

slaren commented Mar 11, 2024

I found it a bit confusing that in llama_context_params this parameter is called n_parallel, and then n_seq_max everywhere else.

@ggerganov ggerganov merged commit 05b0621 into master Mar 11, 2024
51 of 64 checks passed
@ggerganov ggerganov deleted the gg/counts-consistency branch March 11, 2024 15:49
NeoZhangJianyu pushed a commit to NeoZhangJianyu/llama.cpp that referenced this pull request Mar 12, 2024
@ggerganov @NeoZhangJianyu
llama : more consistent names of count variables (ggerganov#5994)
f6846a3 
* llama : more consistent names of count variables

ggml-ci

* llama : n_parallel -> n_seq_max

* common : fix param name

* examples : fix param name
jordankanter pushed a commit to jordankanter/llama.cpp that referenced this pull request Mar 13, 2024
@ggerganov @jordankanter
llama : more consistent names of count variables (ggerganov#5994)
5577811 
* llama : more consistent names of count variables

ggml-ci

* llama : n_parallel -> n_seq_max

* common : fix param name

* examples : fix param name
hodlen pushed a commit to hodlen/llama.cpp that referenced this pull request Apr 1, 2024
@ggerganov @hodlen
llama : more consistent names of count variables (ggerganov#5994)
56ae1ed 
* llama : more consistent names of count variables

ggml-ci

* llama : n_parallel -> n_seq_max

* common : fix param name

* examples : fix param name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ggerganov @slaren