-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] API refactor #156
base: main
Are you sure you want to change the base?
[WIP] API refactor #156
Conversation
Okay, thanks! Just a quick glance: First, let's leave Telescope out of this PR completely, as this refactor is much more general, and limit additions to the documentation to the actual API changes, if there will be. (An extension plugin/gist/snippet can be shared anytime.) I don't understand the motivation behind moving That said, yep, we should probably introduce "ranges" as a concept somehow. But that should cover search, backdrop & beacons too. Fennel tips:
|
493b49a
to
b7ed1ec
Compare
Hey thanks. You will have to bear with me for a while as I am learning Fennel hahaha. I had moved |
…ght state) and extract `exit` function
(fn set-label-states [targets {: group-offset}] | ||
(let [|label-set| (length targets.label-set) | ||
offset (* group-offset |label-set|) | ||
primary-start (+ offset (if targets.autojump? 2 1)) | ||
primary-start (+ offset 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be okay since it looks like the label will be nil
in this case anyways
Addresses #151. I'm making this PR right away so you can stay updated on my progress, and I will try to keep the commits as atomic as possible. Feel free to chime in anytime if something doesn't look right to you.