-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Iced 0.13.1 #9
Draft
ggand0
wants to merge
19
commits into
main
Choose a base branch
from
iced-0.13.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing fields and updates styled() to address errors.
- Upgraded the menu to use iced_aw's new Menu APIs. - Refactored custom button styles to use the new styling APIs. - Skipped updating menu_1 for now to prioritize fixing other errors.
- Use `iced::application(...).run_with()` - Migrate keyboard event handling to the new API - Update Commands to Tasks
Use keyboard::on_key_press and on_key_release listeners instead of Event::Keyboard events.
Using a custom struct name for State (e.g. SplitState) seems to cause a runtime error.
- Ensure `on_event()` of the second element is called in Split - Fix message publishing blocks in DualSlider
Fixes the issue where images overlap with selection rectangles.
- Load fonts via Settings - Fix footer text not rendered with monospace font
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #8