Skip to content

Implements #8875: Using binding_array should require an enable extension#9298

Open
39ali wants to merge 13 commits intogfx-rs:trunkfrom
39ali:enable-binding-buffer
Open

Implements #8875: Using binding_array should require an enable extension#9298
39ali wants to merge 13 commits intogfx-rs:trunkfrom
39ali:enable-binding-buffer

Conversation

@39ali
Copy link
Copy Markdown
Contributor

@39ali 39ali commented Mar 25, 2026

Connections
Fixes #8875

Description
this requires wgpu_binding_array to be enabled in the shader to use binding_array

Testing
i added some tests to test this feature

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

Copy link
Copy Markdown
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jimblandy
Copy link
Copy Markdown
Member

I believe the failing CI are simply requiring that you update the snapshot output files. Be sure you're running cargo test with --all-features.

@39ali
Copy link
Copy Markdown
Contributor Author

39ali commented Mar 26, 2026

@jimblandy not sure what's wrong with the changelog

@inner-daemons
Copy link
Copy Markdown
Collaborator

@jimblandy Can you hold off on merging this PR for a while, DMed you

@ErichDonGubler
Copy link
Copy Markdown
Member

@39ali:

…not sure what's wrong with the changelog

If you read the log in CI ([link] (https://github.com/gfx-rs/wgpu/actions/runs/23599656223/job/68725798927?pr=9298#step:3:47)), you see this message:

Found hunk(s) in released sections of ./CHANGELOG.md, which we don't want:

A release happened since you started this PR, so you need to move this line up to the new Unreleased section.

I bet it'd be helpful to include this above as a hint. I'll file a PR for that. 😁

@39ali 39ali force-pushed the enable-binding-buffer branch from f2c2c74 to cf6503d Compare March 28, 2026 15:40
@39ali
Copy link
Copy Markdown
Contributor Author

39ali commented Mar 28, 2026

fixed the changelog but i think it broke because of the squash :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using binding_array should require an enable extension

4 participants