fix(changelog): detect deleted release sections#9255
Open
teddygood wants to merge 4 commits intogfx-rs:trunkfrom
Open
fix(changelog): detect deleted release sections#9255teddygood wants to merge 4 commits intogfx-rs:trunkfrom
teddygood wants to merge 4 commits intogfx-rs:trunkfrom
Conversation
teddygood
force-pushed
the
fix-changelog-deleted-release-sections
branch
from
cca1f97 to
575cf24
Compare
teddygood
force-pushed
the
fix-changelog-deleted-release-sections
branch
from
575cf24 to
b7a30db
Compare
Member
|
I'll take on reviewing this, though I likely won't be able to finish a review until early next week. I've updated the OP to remove the PR checklist, since it's not useful here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #9245.
Description
The changelog check previously only used post-change line positions, which let deletions of already-released sections slip through. This switches the check to track both old and new hunk positions and adds a regression test.