Open
Conversation
atlv24
reviewed
Mar 14, 2026
atlv24
reviewed
Mar 14, 2026
atlv24
reviewed
Mar 14, 2026
Co-authored-by: atlv <email@atlasdostal.com>
Contributor
cwfitzgerald
approved these changes
Mar 26, 2026
| naga-validate-macos: | ||
| name: "Validate: MSL" | ||
| runs-on: macos-15 | ||
| runs-on: macos-26 |
Collaborator
Author
There was a problem hiding this comment.
Basically in order to compile the shaders you need a recent enough xcode version. Idk how else to force that, and I think they're somewhat tied to the OS.
Per-vertex is funky, it can only run on M4 and up anyway, so its not like we would be able to test the functionality. But I figured it would be ok to validate the shaders on a recent enough os version.
| }) => { | ||
| writeln!( | ||
| self.out, | ||
| "{0}{{ {1}.{2}.get({NAMESPACE}::vertex_index::first), {1}.{2}.get({NAMESPACE}::vertex_index::second), {1}.{2}.get({NAMESPACE}::vertex_index::third) }}", |
Collaborator
Author
There was a problem hiding this comment.
HLSL is 10000x worse lol but yeah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Connections
Closes #9117
Description
Adds support for per vertex fragment inputs on MSL and HLSL. Also adds some extra valiadtion that is related, plus an enable extension.
Testing
Existing tests
Squash or Rebase?
Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.