Open
Conversation
inner-daemons
approved these changes
Mar 20, 2026
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
Two questions, otherwise lgtm
| let stdout = String::from_utf8_lossy(&output.stdout).replace("\r\n", "\n"); | ||
|
|
||
| if !output.status.success() { | ||
| let mut commented = String::new(); |
Collaborator
There was a problem hiding this comment.
Maybe add an extra line like "spirv-cross error:", this also makes errors more searchable
| Some(&pipeline_options), | ||
| &format!("{}.spvasm", ep.name), | ||
| ); | ||
| write_spirv_cross_glsl( |
Collaborator
There was a problem hiding this comment.
I wonder if in this case we should still combine them into one file, even if the spirv entry points will be written separately?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Closes #9190
Description
This helps make the diffs clearer when modifying spirv output. Basically all of them translate correctly.
Testing
Tested in CI.
Squash or Rebase?
Commit