[core] Implement WebGPUError for WaitIdleError.#9128
Open
jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Open
[core] Implement WebGPUError for WaitIdleError.#9128jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
Implement the `wgpu_types::error::WebGpuError` categorization trait for `wgpu_core::device::life::WaitIdleError`, so that the latter can be properly reported to users of the WebGPU API.
jimblandy
force-pushed
the
impl-webgpuerror-for-waitidleerror
branch
from
5526e4e to
db17312
Compare
teoxoy
reviewed
Mar 3, 2026
| match self { | ||
| WaitIdleError::Device(device_error) => device_error.webgpu_error_type(), | ||
| WaitIdleError::WrongSubmissionIndex(_, _) | WaitIdleError::Timeout => { | ||
| ErrorType::Internal |
Member
There was a problem hiding this comment.
The spec only allows generating internal errors at pipeline creation time (it was needed to support FXC, but since we dropped support for FXC we should ideally never use this variant).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the
wgpu_types::error::WebGpuErrorcategorization trait forwgpu_core::device::life::WaitIdleError, so that the latter can be properly reported to users of the WebGPU API.