-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Playwright wasm tests #9114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Playwright wasm tests #9114
Changes from all commits
33ea7ef
5585286
c34ee01
0370617
f22c40a
4591cb2
fac431a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -87,6 +87,7 @@ trybuild.workspace = true | |
| cargo_metadata.workspace = true | ||
| env_logger.workspace = true | ||
| parking_lot = { workspace = true, features = ["deadlock_detection"] } | ||
| ureq.workspace = true | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: as we don't need tls, it is possible that we turn it off to prevent taking in deps on the TLS stack? |
||
|
|
||
| [target.'cfg(not(any(target_arch = "wasm32", miri)))'.dependencies] | ||
| nv-flip.workspace = true | ||
|
|
@@ -95,7 +96,9 @@ nv-flip.workspace = true | |
| [target.'cfg(target_arch = "wasm32")'.dependencies] | ||
| console_log.workspace = true | ||
| wasm-bindgen.workspace = true | ||
| wasm-bindgen-futures.workspace = true | ||
| web-sys = { workspace = true } | ||
| parking_lot = { workspace = true, features = ["deadlock_detection"] } | ||
|
|
||
| # Webassembly Dev Dependencies | ||
| [target.'cfg(target_arch = "wasm32")'.dev-dependencies] | ||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,6 +12,8 @@ mod params; | |||||
| mod poll; | ||||||
| mod report; | ||||||
| mod run; | ||||||
| pub mod wasm; | ||||||
| pub mod wasm_manager; | ||||||
|
|
||||||
| #[cfg(target_arch = "wasm32")] | ||||||
| pub use init::initialize_html_canvas; | ||||||
|
|
@@ -120,7 +122,11 @@ pub fn did_oom<T>(device: &wgpu::Device, callback: impl FnOnce() -> T) -> (bool, | |||||
| macro_rules! gpu_test_main { | ||||||
| ($tests: expr) => { | ||||||
| #[cfg(target_arch = "wasm32")] | ||||||
| wasm_bindgen_test::wasm_bindgen_test_configure!(run_in_browser); | ||||||
| #[wasm_bindgen::prelude::wasm_bindgen] | ||||||
| pub fn run_test(test_name: String) { | ||||||
| $crate::wasm::main($tests, test_name); | ||||||
| } | ||||||
|
|
||||||
| #[cfg(target_arch = "wasm32")] | ||||||
| fn main() { | ||||||
| // Ensure that value is used so that warnings don't happen. | ||||||
|
|
@@ -129,7 +135,11 @@ macro_rules! gpu_test_main { | |||||
|
|
||||||
| #[cfg(not(target_arch = "wasm32"))] | ||||||
| fn main() -> $crate::native::MainResult { | ||||||
| $crate::native::main($tests) | ||||||
| if std::env::var("TEST_WASM") == Ok("true".to_string()) { | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
super nit |
||||||
| $crate::wasm_manager::run_wasm_browser_tests($tests) | ||||||
| } else { | ||||||
| $crate::native::main($tests) | ||||||
| } | ||||||
| } | ||||||
| }; | ||||||
| } | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this about?