Conversation
This comment was marked as outdated.
This comment was marked as outdated.
evilpie
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
ErichDonGubler
changed the title
evilpie
force-pushed
the
vendor
branch
2 times, most recently
from
3e1d8f6 to
0d45ff2
Compare
|
Might as well wait for VideoFrame to become stable. |
|
That may that months or years, so id prefer us to also vendor video frame for the compiler, but not expose it. |
|
VideoFrame would be in the next release. wasm-bindgen/wasm-bindgen#5008 |
|
Oh nice, alright! |
| wgt::ExternalImageSource::VideoFrame(ref v) => unsafe { | ||
| todo!() | ||
| /* | ||
| gl.tex_sub_image_3d_with_video_frame( |
There was a problem hiding this comment.
Almost ready, but for some reason this method doesn't exist. @cwfitzgerald any ideas?
There was a problem hiding this comment.
Yeah the problem is that it too is behind a cfg(web_sys_unstable_apis) so this would need a PR to glow to remove it https://docs.rs/crate/glow/latest/source/src/web_sys.rs#1402-1437.
Up to you the order which this happens.
There was a problem hiding this comment.
I opened a PR grovesNL/glow#361, but glow seems to be released quite seldom.
2 participants
Connections
Description
This updates the WebGPU binding from wasm-bindgen/web-sys to the latest version. I had to modify the vendor script, because it can now reference other kind of ExternalResources, in particular the still unstable VideoFrame.
Testing
Explain how this change is tested.
Squash or Rebase?
Rebase
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.