Skip to content

[spirv-out] Prevent naga crashing on an aliased ray query. #7759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

Vecvec
Copy link
Collaborator

@Vecvec Vecvec commented Jun 6, 2025

Connections

Description
Stumbled across this issue where when a ray query is used in an alias spirv-out crashes naga. This is because it only searches for ray queries without names. Instead, use a local type to be written out.

Testing
Adds snapshot test which failed before but now works.

Squash or Rebase?
One commit, so probably doesn't matter.

Checklist

  • Run cargo fmt.
  • Run cargo clippy --tests.
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@Vecvec Vecvec force-pushed the fix-aliased-ray-queries branch 2 times, most recently from 52eec72 to a2eca61 Compare June 6, 2025 22:10
Copy link
Member

@jimblandy jimblandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Thanks for putting all the Writer type helpers to good use.

@Vecvec Vecvec force-pushed the fix-aliased-ray-queries branch from a2eca61 to d936385 Compare June 12, 2025 08:01
@teoxoy teoxoy enabled auto-merge (squash) June 16, 2025 08:25
@teoxoy teoxoy merged commit 03775c5 into gfx-rs:trunk Jun 16, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants