-
Notifications
You must be signed in to change notification settings - Fork 1.1k
MVP no_std
for wgpu
#7747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
MVP no_std
for wgpu
#7747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preserves current behaviour
This reverts commit d8db90f.
Required until a `send_sync` compatible alternative `Mutex` implementation is available (e.g., `spin`)
Wumpf
requested changes
Jun 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, a few requests regarding documentation
Co-Authored-By: Andreas Reich <[email protected]>
Wumpf
approved these changes
Jun 10, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Description
parking_lot
andstd
features towgpu
, allowing for compilation onwasm32v1-none
with said features disabled.Mutex
wrapper to handle selecting a non-parking_lot
implementation.StagingBelt
behindstd
as it requires access to a channel implementation (std::sync::mpsc
) to function. This could be replaced withConcurrentQueue
but that will require adding a new dependency towgpu
(although it is already in the lockfile as a dev-dependency)wgpu
to theno_std
CI taskTesting
Squash or Rebase?
Squash
Checklist
cargo fmt
.taplo format
.cargo clippy --tests
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.