Skip to content

DX12: Align copies b/w textures and buffers when D3D12_FEATURE_DATA_D3D12_OPTIONS13.UnrestrictedBufferTextureCopyPitchSupported is false #7721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from
Open

DX12: Align copies b/w textures and buffers when D3D12_FEATURE_DATA_D3D12_OPTIONS13.UnrestrictedBufferTextureCopyPitchSupported is false #7721

wants to merge 5 commits into from

Conversation

ErichDonGubler
Copy link
Member

Connections

Testing

  • TODO: Will prove that this works even when forced to align. This won't definitively prove that we're fixing cases that need this, but it will prove that we're not breaking anything with intermediate buffers.

Squash or Rebase?

rebase plz

Checklist

  • If this contains user-facing changes, add a CHANGELOG.md entry.

@ErichDonGubler ErichDonGubler force-pushed the dx12-aligned-texbuf-copy-offset branch from 612dc54 to 60d2d96 Compare May 24, 2025 13:13
@jimblandy jimblandy mentioned this pull request Jun 3, 2025
Open
@ErichDonGubler
Copy link
Member Author

I'm...honestly not sure why this is failing on the wgpu_gpu::regression::issue_6827::test_scatter test entry in CI. I think I need some help. Marking as ready for review; perhaps @teoxoy or @cwfitzgerald could help me out?

@ErichDonGubler ErichDonGubler marked this pull request as ready for review June 13, 2025 07:50
@ErichDonGubler ErichDonGubler requested a review from a team as a code owner June 13, 2025 07:50
ErichDonGubler
ErichDonGubler commented Jun 13, 2025
View reviewed changes
wgpu-hal/src/dx12/mod.rs
for cmd_buf in command_buffers {
temp_lists.push(Some(cmd_buf.raw.clone().into()));
intermediate_copy_bufs.push(Arc::clone(&cmd_buf.intermediate_copy_bufs));
// TODO: When to clean accumulated copy buffers up?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking that the best time to clean these up might be during a Poll, where we can guarantee that temporary buffers are no longer necessary. Validation, please? 🥺

@ErichDonGubler ErichDonGubler force-pushed the dx12-aligned-texbuf-copy-offset branch from 60d2d96 to 505438d Compare June 13, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[d3d12] Panic in end_encoding [d3d12] Support non-default rows_per_image for 3D texture writes
1 participant
@ErichDonGubler