-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paired tumor normal calling #5
base: main
Are you sure you want to change the base?
Conversation
caalo
commented
Mar 12, 2024
•
edited
Loading
edited
- Added parameter_meta
- Reduced the number of private variables for MarkDuplicates
- Removed old comments
Our final version is paired tumor normal calling: tumor1-normal1, tumor2-normal2 calling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments for change
@@ -1,6 +1,8 @@ | |||
{ | |||
"mutation_calling.tumorFastq": ["/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/HCC4006_final.fastq", "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/CALU1_combined_final.fastq"], | |||
"mutation_calling.normalFastq": "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/MOLM13_combined_final.fastq", | |||
"mutation_calling.samples": [{"tumorSample": "/fh/fast/paguirigan_a/pub/ReferenceDataSets/workflow_testing_data/WDL/wdl_101/HCC4006_final.fastq", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided that the path will be required to be put in by the reader?
Maybe for testing we can keep this but for the final one we maybe want to say something like /path/to/tumor/1/fastq or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the Fred Hutch json! There's a separate one for non-Fred Hutch (although there is still FH paths in it). I think you created these files so you can make any changes to them if you desire!
|
||
# Align fastq file to the reference genome | ||
task BwaMem { | ||
input { | ||
File input_fastq | ||
referenceGenome refGenome | ||
Int threads = 16 | ||
} | ||
|
||
String base_file_name = basename(input_fastq, ".fastq") | ||
String ref_fasta_local = basename(refGenome.ref_fasta) | ||
|
||
String read_group_id = "ID:" + base_file_name | ||
String sample_name = "SM:" + base_file_name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had put SM but we can change to anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Feel free to make any commits to change that
} | ||
|
||
String base_file_name = basename(input_fastq, ".fastq") | ||
String ref_fasta_local = basename(refGenome.ref_fasta) | ||
|
||
String read_group_id = "ID:" + base_file_name | ||
String sample_name = "SM:" + base_file_name | ||
String platform = "illumina" | ||
String platform_info = "PL:" + platform # Create the platform information | ||
String platform_info = "PL:illumina" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept that platform variable so that people can add as they please? But i guess for this guide it is okay to expect illumina.