Skip to content

Commit

Permalink
remove FIXME for aws_s3_policy_doc_create and open an issue for it on gh
Browse files Browse the repository at this point in the history
  • Loading branch information
sckott committed Jul 24, 2024
1 parent e2b3b02 commit c0b66ee
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions R/s3.R
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ s3_actions_full <- function() {
#' )
aws_s3_policy_doc_create <- function(bucket, action, resource, effect = "Allow",
sid = NULL, ...) {
# FIXME: one can put more than 1 statement in the Statement slot -
# the below line about adding a `sid` assumes there's only 1 - which
# does work cause we hard code just 1 statement here. Should we
# support more? probably
doc <- list(
Version = "2012-10-17",
Statement = list(
Expand Down

0 comments on commit c0b66ee

Please sign in to comment.