Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wikijs repo fix #2273

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Wikijs repo fix #2273

merged 3 commits into from
Feb 27, 2025

Conversation

al-lac
Copy link
Contributor

@al-lac al-lac commented Feb 26, 2025

This update adds the repo folder to wikijs to fix permissions errors when using the git sync feature.

Fixes #2176.

Maybe you can test and take a look at the new hook @nmfretz.

Copy link

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

@nmfretz
Copy link
Contributor

nmfretz commented Feb 27, 2025

Reviewed and tested. Great work remembering to update the umbrel.yaml manifest version to 1.1 with the inclusion of the hook. And also good find on the container not running as user 1000:1000 even though it is a linuxserver image which usually abide by the PUID/PGID environment variables.

I have tweaked the hook very slightly to take into account that all previous installs of wikijs on umbrel will already have the data/ and config/ bind mounts created. I also updated the comments slightly to remind us why we do specific things.

wikijs now runs as 1000:1000:

$ sudo docker exec wikijs_server_1 id
uid=1000 gid=1000(users) groups=1000(users)

@nmfretz nmfretz merged commit 570a9d4 into getumbrel:master Feb 27, 2025
1 check passed
@al-lac al-lac deleted the wikijs-repo-fix branch February 27, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WikiJS Git Permissions Error
2 participants