App Submission: Pluto

[whirmill]

App Submission

App name

Pluto

256x256 SVG icon

https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/Pluto+Logo.svg

Gallery images

https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/plutomining-next/screenshot_00.png
https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/plutomining-next/screenshot_01.png
https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/plutomining-next/screenshot_02.png
https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/plutomining-next/screenshot_03.png
https://bemind-umbrel-app-store.s3.eu-south-1.amazonaws.com/plutomining-next/screenshot_04.png

I have tested my app on:

• umbrelOS on a Raspberry Pi
• umbrelOS on an Umbrel Home
• umbrelOS on Linux VM

[whirmill]

the missing folders warnings are handled in the pre-start hook.
the discovery service needs to be on the host network.

[github-actions]

🎉   Linting finished with no errors or warnings   🎉

Thank you for your submission! This is an automated linter that checks for common issues in pull requests to the Umbrel App Store.

Please review the linting results below and make any necessary changes to your submission.

Linting Results

Severity	File	Description
ℹ️	pluto/docker-compose.yml	Service "discovery" uses host network mode: The host network mode can lead to security vulnerabilities. If possible please use the default bridge network mode and expose the necessary ports.

Legend

Symbol	Description
❌	Error: This must be resolved before this PR can be merged.
⚠️	Warning: This is highly encouraged to be resolved, but is not strictly mandatory.
ℹ️	Info: This is just for your information.

[whirmill]

what's next?

[nmfretz]

Thanks for this submission @whirmill, and for making changes based on the linter!

We've got our head down elsewhere right now, but will try and review this next week. Thanks for your patience.

[whirmill]

Hi,

Just checking in to see if there’s been any progress on this PR or if any additional input is needed from my side. I’d be happy to make adjustments or provide clarification if necessary. Let me know how we can move forward.

Thanks for your time!

[DerekBlueEyes]

@nmfretz Pluto was intended to be a Umbrel first product, after more than 2 month if you don't wanna put Pluto on the store just tell us and we will change Product Launch approach.
Meanwhile we are forced to diversify the application and move on Start9.

let us know :D

p.s. just to be clear: no hard feelings, we are just stuck.

[nmfretz]

@whirmill @DerekBlueEyes I'm very sorry for the delay on my end! Thanks for being so patient. I'm able to work on app submission PRs this week, so will help get this to the app store 🚀

Meanwhile we are forced to diversify the application

This is a fantastic idea anyways, since you'll be able to maximize your userbase, as well as structure the app in such a way that it doesn't matter where it is run.

I have left a review below.

[nmfretz]

This comment relates to the entire conf/ directory:

One consideration for you here is that on app install everything from an app's repo is copied over, but on an app update, only a whitelist of files are copied:
https://github.com/getumbrel/umbrel/blob/bd8ced1b193d6d0eaa4a6811ba5a8c0cbb6776f2/packages/umbreld/source/modules/apps/legacy-compat/app-script#L662-L668

# App updates will only copy files from this whitelist:
UPDATE_FILES_WHITELIST_PRE="docker-compose.yml *.template exports.sh torrc hooks"

The idea here is that a user's app data doesn't get nuked on app update.

But what this means then is that if you need to make a change to the contents of a file in the conf/ directory, it will work for fresh app installs, but existing installs won't get the changes when they update. If you needed to make a change to these files (say like changing the port in the datasource.yaml) then you'd need to add some logic in a pre-start hook to handle this.

The other option here would be to package your own Docker images for grafana, prometheus, etc that give you a way to easily update these files for users.

[nmfretz]

Do you know if pid is required in all the containers, or can we remove it? The goal here is to keep container permissions as low as possible without impacting app functionality

[nmfretz]

Fantastic work using the full container names for services here and elsewhere in this compose file 👌

[nmfretz]

Does prometheus need to run as user 65534? I see that in the pre-start hook you are chowning the data dir for prometheus as 1000.

[nmfretz]

Does grafana need to run as user 472? I see that in the pre-start hook you are chowning the data dir for grafana as 1000.

[nmfretz]

This entire pre-start hook might be unnecessary.

When an app is installed on umbrelOS, the initial directories/files that are in this repo are created with user 1000:1000 permissions. So everything under pluto/conf/ and pluto/data/ will already be set up with those permissions.

A related thing here though is that I see the prometheus and grafana services in the compose file are defined with non-1000 users. Can these both be run as user 1000 as well?

[nmfretz]

If you end up needing to keep the pre-start hook then this version needs to be 1.1. If the hook is removed then this can stay as 1

[nmfretz]

You can add a short tagline here so that users can see at a glance what Pluto is when they are browsing the app store. For example, you could do something like:

Manage and monitor open-source bitcoin mining devices

[nmfretz]

Also, @whirmill @DerekBlueEyes, do you guys have any ideas for text to include at the top of each gallery image? If you can come up with some, we'll get started on the gallery assets.