Add separate subcommands for encryption, decryption, rotating, editing, and setting values #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
subcommands
branch
from
e08d227
to
4b4f1c4
Compare
felixfontein
changed the title
felixfontein
force-pushed
the
subcommands
branch
from
4b4f1c4
to
0a6d2e4
Compare
Ph0tonic
reviewed
Nov 8, 2023
Comment on lines
+678
to
+689
| cli.BoolFlag{ | ||
| Name: "yes, y", | ||
| Usage: `pre-approve all changes and run non-interactively`, | ||
| }, |
| []cli.Flag{ | ||
| cli.StringFlag{ | ||
| Name: "file, f", | ||
| Usage: "the file to add the group to", |
There was a problem hiding this comment.
Maybe we should write the file to delete the group key from
Comment on lines
+422
to
+433
| cli.BoolFlag{ | ||
| Name: "yes, y", | ||
| Usage: `pre-approve all changes and run non-interactively`, | ||
| }, |
Comment on lines
+1347
to
+1368
| cli.BoolFlag{ | ||
| Name: "verbose", | ||
| Usage: "Enable verbose logging output", | ||
| }, |
Comment on lines
+434
to
+445
| cli.BoolFlag{ | ||
| Name: "verbose", | ||
| Usage: "Enable verbose logging output", | ||
| }, |
Comment on lines
+349
to
+360
| cli.BoolFlag{ | ||
| Name: "background", | ||
| Usage: "background the process and don't wait for it to complete", | ||
| }, |
Comment on lines
+295
to
+306
| cli.BoolFlag{ | ||
| Name: "background", | ||
| Usage: "background the process and don't wait for it to complete", | ||
| }, |
felixfontein
force-pushed
the
subcommands
branch
from
7e50f4a
to
1e64a07
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
felixfontein
force-pushed
the
subcommands
branch
from
1e64a07
to
8b1c7ce
Compare
My goal with this PR for now is to check out how creating subcommands could work. There are quite a few PRs waiting to get processed that add a lot of rebase work to this one, so I might also just ditch it and re-start from scratch. Thanks for marking the other ones, I'll take a look at them at some point once this is more stable... |
When warning, also inform about potentially ignored flags. Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
felixfontein
force-pushed
the
subcommands
branch
from
8b1c7ce
to
fe65b43
Compare
This was referenced Dec 26, 2023
|
@felixfontein can this PR be closed, now that #1391 is merged? |
|
This is maily still open for the flag de-duplication. I wanted to continue working on this once some more PRs are merged, which unfortunately never happened until now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a Work in Progress for exploring how to implement #1333. Right now the new subcommands are basically a stripped-down copy'n'paste of the current "main" command.
Fixes #1333