-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
ref(analytics): Transform analytics events for TET-837 #95216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Transform event classes to use @analytics.eventclass decorator - Transform analytics.record calls to use event class instances - Update imports as needed Closes TET-837
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #95216 +/- ##
==========================================
- Coverage 80.97% 80.63% -0.34%
==========================================
Files 8531 8415 -116
Lines 376699 375156 -1543
Branches 23889 23634 -255
==========================================
- Hits 305032 302515 -2517
- Misses 71300 72283 +983
+ Partials 367 358 -9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relocation event changes look good to me.
This issue has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you remove the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Closes TET-837
Requires https://github.com/getsentry/getsentry/pull/18275