Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(ddm): Clean up unused options and feature flags #70736

Merged
merged 3 commits into from May 14, 2024

Conversation

iambriccardo
Copy link
Member

@iambriccardo iambriccardo commented May 13, 2024

This PR removes some unused feature flags and options that were needed for DDM.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
@iambriccardo iambriccardo marked this pull request as ready for review May 13, 2024 10:49
Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.02%. Comparing base (dd70023) to head (77ab399).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #70736      +/-   ##
==========================================
- Coverage   80.02%   80.02%   -0.01%     
==========================================
  Files        6505     6503       -2     
  Lines      290784   290644     -140     
  Branches    50109    50087      -22     
==========================================
- Hits       232710   232592     -118     
+ Misses      57637    57615      -22     
  Partials      437      437              
Files Coverage Δ
src/sentry/conf/server.py 89.42% <ø> (ø)
src/sentry/options/defaults.py 100.00% <ø> (ø)

... and 25 files with indirect coverage changes

@shellmayr
Copy link
Member

The flag 'custom-metrics-experimental' seems to be used in quite some parts of the front-end through hasMetricsExperimentalFeature - should this be cleaned up together?

@iambriccardo
Copy link
Member Author

The flag 'custom-metrics-experimental' seems to be used in quite some parts of the front-end through hasMetricsExperimentalFeature - should this be cleaned up together?

Good catch, I forgot frontend uses options with implicit organizations: prefix.

@iambriccardo iambriccardo merged commit 27fd431 into master May 14, 2024
49 checks passed
@iambriccardo iambriccardo deleted the riccardo/ref/remove-options branch May 14, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants