fix: Screenshot Capture #2240
Draft
fix: Screenshot Capture #2240
+81
−111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Screenshot Capture ([#2240](https://github.com/getsentry/sentry-unity/pull/2240))If none of the above apply, you can opt out of this check by adding |
| { | ||
| return @event; | ||
| _options = sentryOptions; | ||
| _sentryMonoBehaviour = sentryMonoBehaviour ?? SentryMonoBehaviour.Instance; |
There was a problem hiding this comment.
We have a public ctor that passes SentryMonoBehaviour.Instance already, having also ?? seems redundant.
Since this is an internal ctor, how about:
Suggested change
| _sentryMonoBehaviour = sentryMonoBehaviour ?? SentryMonoBehaviour.Instance; | |
| _sentryMonoBehaviour = sentryMonoBehaviour ?? throw new ArgumentNullException("sentryMonoBehaviour"); |
|
|
||
| public void CaptureScreenshotForEvent(SentryUnityOptions options, SentryId eventId) | ||
| { | ||
| StartCoroutine(CaptureScreenshot(options, eventId)); |
There was a problem hiding this comment.
This method returns before the coroutine starts/ends, right? how do we know the screenshot will be taken before the event is created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2224, #1827 🎉
The SDK has to wait for the
EndOfFrameto capture a screenshot. The behaviour is unreliable otherwise.Since we're now waiting for
EndOfFramewe can now also make sure not to capture more than one screenshot per frame.Open Question
But that also means, that only the first error in a given frame has a screenshot attached to it?
Do we send the same screenshot multiple times, for each error?