chore: Download the Cocoa SDK instead of building it
#1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
approved these changes
Oct 21, 2024
| Plugins/iOS/Sentry.xcframework~/Info.plist | ||
| Plugins/iOS/Sentry.xcframework~/tvos-arm64/dSYMs/ |
There was a problem hiding this comment.
does it make sense to ship tvos and watchos?
There was a problem hiding this comment.
Unity has these as build targets. We don't specifically have support for those (yet) but it doesn't make sense to me to fix (trim) up the .xcframework.
brustolin
approved these changes
Oct 21, 2024
|
@vaind does the dependency updater work on this now too? |
yes, it uses the .properties file: https://github.com/getsentry/sentry-unity/blob/03d455664c3f39ec9e00598f043e3ff427470655/modules/sentry-cocoa.properties |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog