Allow to install the bundle without Symfony security #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluxetom
approved these changes
Feb 26, 2025
Jean85
reviewed
Feb 26, 2025
welcoMattic
approved these changes
Feb 27, 2025
|
Wohoo. Thank you for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a semi small micro service running Symfony. We dont use any security feature (it is a private network). I would love to use this package but I also dont want to install dependencies not needed.
I saw that the
symfony/security-coreandsymfony/security-httppackages are only used inLoginListener. I added check to remove that service ifsymfony/security-coreis not installed. I also improved the logic betweensrc/Resources/config/services.xmland the compiler pass.Merging this will not affect existing users, since they either have
symfony/security-corerequired or they are not using it.There is one edge case though. Someone installed this package, configure security (without
symfony/security-bundle) AND did not specifysymfony/security-corein their composer.json. I find that extremely unlikely but I thought I would mention it.