Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): Adds Feedback Widget Maestro E2E tests #4604

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

test(e2e): Adds Feedback Widget Maestro E2E tests #4604

wants to merge 11 commits into from
+213 −8

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Feb 26, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

Note: I'm targeting main with this PR since the changes involve only additional tests. For the feedback related feature changes/additions (e.g.) I'll use feedback-ui-2

📜 Description

Adds Feedback Widget Maestro E2E tests

💡 Motivation and Context

Part of #4302

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 446.69 ms 447.80 ms 1.12 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
025d490 365.42 ms 404.48 ms 39.06 ms
c398f67 449.64 ms 461.38 ms 11.74 ms
5f03ae9 444.88 ms 448.89 ms 4.01 ms
75774ea 454.16 ms 467.80 ms 13.64 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
8ae23a7 526.83 ms 513.38 ms -13.45 ms
57448c5 443.47 ms 440.20 ms -3.26 ms
0c98663 437.75 ms 420.70 ms -17.05 ms
40c35c5 438.38 ms 437.52 ms -0.86 ms

App size

Revision Plain With Sentry Diff
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
025d490 17.75 MiB 20.12 MiB 2.37 MiB
c398f67 17.73 MiB 19.94 MiB 2.21 MiB
5f03ae9 17.75 MiB 20.11 MiB 2.36 MiB
75774ea 17.74 MiB 20.08 MiB 2.35 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
8ae23a7 17.74 MiB 20.07 MiB 2.34 MiB
57448c5 17.74 MiB 20.08 MiB 2.34 MiB
0c98663 17.75 MiB 20.12 MiB 2.37 MiB
40c35c5 17.75 MiB 20.11 MiB 2.37 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.20 ms 1226.38 ms -8.82 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8bda0cc+dirty 1221.90 ms 1208.11 ms -13.79 ms
80b2ce3+dirty 1265.92 ms 1268.60 ms 2.69 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
db44eaf+dirty 1227.09 ms 1230.65 ms 3.56 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
8ab11b6+dirty 1203.23 ms 1206.02 ms 2.79 ms
1c65324+dirty 1235.17 ms 1235.08 ms -0.09 ms
a0b0298+dirty 1220.73 ms 1226.87 ms 6.14 ms
83f6f6c+dirty 1218.33 ms 1220.27 ms 1.93 ms

App size

Revision Plain With Sentry Diff
8bda0cc+dirty 2.63 MiB 3.70 MiB 1.06 MiB
80b2ce3+dirty 2.36 MiB 2.84 MiB 486.98 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
db44eaf+dirty 2.36 MiB 3.10 MiB 755.81 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
8ab11b6+dirty 2.36 MiB 3.11 MiB 759.83 KiB
1c65324+dirty 2.36 MiB 3.04 MiB 698.64 KiB
a0b0298+dirty 2.63 MiB 3.75 MiB 1.12 MiB
83f6f6c+dirty 2.36 MiB 3.10 MiB 759.79 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 364.84 ms 387.94 ms 23.09 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5571a20+dirty 359.52 ms 389.80 ms 30.28 ms
c71ea72+dirty 410.57 ms 472.63 ms 62.06 ms
79976dd+dirty 373.25 ms 404.64 ms 31.39 ms
686b3bc+dirty 363.48 ms 356.17 ms -7.31 ms
488c9c5+dirty 448.98 ms 531.62 ms 82.64 ms
30189be+dirty 362.02 ms 386.80 ms 24.78 ms
b95b8af+dirty 392.94 ms 428.00 ms 35.06 ms
fc150fe+dirty 409.55 ms 407.37 ms -2.18 ms
e73d82f+dirty 377.67 ms 407.06 ms 29.39 ms
c314a21+dirty 419.41 ms 426.02 ms 6.61 ms

App size

Revision Plain With Sentry Diff
5571a20+dirty 7.15 MiB 8.20 MiB 1.05 MiB
c71ea72+dirty 7.15 MiB 8.38 MiB 1.23 MiB
79976dd+dirty 7.15 MiB 8.38 MiB 1.23 MiB
686b3bc+dirty 7.15 MiB 8.38 MiB 1.23 MiB
488c9c5+dirty 7.15 MiB 8.38 MiB 1.23 MiB
30189be+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b95b8af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
fc150fe+dirty 7.15 MiB 8.38 MiB 1.23 MiB
e73d82f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
c314a21+dirty 7.15 MiB 8.39 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 26, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.67 ms 1219.34 ms -5.33 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8bda0cc+dirty 1217.90 ms 1223.02 ms 5.12 ms
80b2ce3+dirty 1245.12 ms 1262.04 ms 16.92 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
db44eaf+dirty 1238.49 ms 1236.56 ms -1.93 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
8ab11b6+dirty 1222.91 ms 1216.08 ms -6.83 ms
1c65324+dirty 1239.71 ms 1239.86 ms 0.15 ms
a0b0298+dirty 1227.71 ms 1234.12 ms 6.41 ms
83f6f6c+dirty 1232.02 ms 1229.15 ms -2.87 ms

App size

Revision Plain With Sentry Diff
8bda0cc+dirty 3.19 MiB 4.26 MiB 1.08 MiB
80b2ce3+dirty 2.92 MiB 3.40 MiB 492.75 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
db44eaf+dirty 2.92 MiB 3.66 MiB 761.15 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
8ab11b6+dirty 2.92 MiB 3.67 MiB 772.38 KiB
1c65324+dirty 2.92 MiB 3.61 MiB 705.56 KiB
a0b0298+dirty 3.19 MiB 4.32 MiB 1.13 MiB
83f6f6c+dirty 2.92 MiB 3.67 MiB 772.37 KiB

@antonis antonis changed the title test(e2e): Feedback Widget Maestro tests test(e2e): Adds Feedback Widget Maestro E2E tests Mar 5, 2025
@antonis antonis mentioned this pull request Mar 5, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich will be requested when the pull request is marked ready for review krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman will be requested when the pull request is marked ready for review lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@antonis