chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414

antonis · 2025-01-03T10:16:39Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Bumps TestAppPlain/TestAppSentry performance test apps from RN 0.70.6 to 0.70.15 that includes the Boost fix.
Also increases iOS binary size diff by 100KB since the tests were consistently failing after the RN version bump.

💡 Motivation and Context

Fixes #4413

💚 How did you test it?

CI

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

This PR aims to tackle the CI failure with the minimum possible changes. As a next step we should consider upgrading
our performance test apps (TestAppPlain/TestAppSentry) on the latest RN version.
⚠️ The binary size bump should be revisited but I considered that this is needed at this point to unblock the CI and the release process.

#skip-changelog

github-actions · 2025-01-03T10:49:44Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	415.65 ms	450.27 ms	34.61 ms
Size	7.15 MiB	8.38 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`690220d`+dirty	492.10 ms	473.88 ms	-18.23 ms
`8e80789`+dirty	464.48 ms	551.10 ms	86.63 ms
`d8e8c67`+dirty	363.77 ms	408.66 ms	44.89 ms
`484813b`+dirty	411.65 ms	456.02 ms	44.37 ms
`13f280b`+dirty	376.13 ms	406.41 ms	30.28 ms
`8ae23a7`+dirty	398.10 ms	411.48 ms	13.38 ms
`12427f4`+dirty	379.48 ms	400.92 ms	21.44 ms
`1faf8e3`+dirty	412.83 ms	470.49 ms	57.66 ms
`0677344`+dirty	288.40 ms	391.44 ms	103.04 ms
`63ed251`+dirty	485.02 ms	531.16 ms	46.14 ms

App size

Revision	Plain	With Sentry	Diff
`690220d`+dirty	7.15 MiB	8.36 MiB	1.21 MiB
`8e80789`+dirty	7.15 MiB	8.37 MiB	1.22 MiB
`d8e8c67`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`484813b`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`13f280b`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`8ae23a7`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`12427f4`+dirty	7.15 MiB	8.12 MiB	997.78 KiB
`1faf8e3`+dirty	7.15 MiB	8.35 MiB	1.20 MiB
`0677344`+dirty	7.15 MiB	8.07 MiB	949.80 KiB
`63ed251`+dirty	7.15 MiB	8.35 MiB	1.20 MiB

github-actions · 2025-01-03T12:28:48Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	428.07 ms	415.18 ms	-12.89 ms
Size	17.75 MiB	20.11 MiB	2.36 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e2b64fe`	316.88 ms	330.23 ms	13.35 ms
`9c48b2c`	349.24 ms	385.96 ms	36.72 ms
`d43a46b`	454.22 ms	477.79 ms	23.57 ms
`8ab11b6`	462.10 ms	450.40 ms	-11.70 ms
`0ebca77`	414.93 ms	444.49 ms	29.56 ms
`62a750b`	395.96 ms	423.36 ms	27.41 ms
`0d3e677`	422.82 ms	411.90 ms	-10.92 ms
`1d86dd6`	405.14 ms	411.06 ms	5.92 ms
`1332acb`	493.40 ms	475.20 ms	-18.21 ms
`9282172`	486.12 ms	467.70 ms	-18.42 ms

App size

Revision	Plain	With Sentry	Diff
`e2b64fe`	17.73 MiB	19.80 MiB	2.07 MiB
`9c48b2c`	17.73 MiB	19.80 MiB	2.07 MiB
`d43a46b`	17.73 MiB	20.06 MiB	2.33 MiB
`8ab11b6`	17.74 MiB	20.09 MiB	2.35 MiB
`0ebca77`	17.73 MiB	19.95 MiB	2.21 MiB
`62a750b`	17.73 MiB	19.93 MiB	2.20 MiB
`0d3e677`	17.74 MiB	20.07 MiB	2.34 MiB
`1d86dd6`	17.73 MiB	19.86 MiB	2.12 MiB
`1332acb`	17.74 MiB	20.09 MiB	2.35 MiB
`9282172`	17.74 MiB	20.09 MiB	2.35 MiB

github-actions · 2025-01-03T14:30:53Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1237.39 ms	1224.72 ms	-12.67 ms
Size	3.19 MiB	4.24 MiB	1.06 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5a22220`+dirty	1246.18 ms	1249.61 ms	3.43 ms
`f06c879`+dirty	1285.14 ms	1285.86 ms	0.72 ms
`c398f67`+dirty	1227.31 ms	1230.00 ms	2.69 ms
`5bb8d5f`+dirty	1215.04 ms	1217.52 ms	2.48 ms
`4cc5c27`+dirty	1220.43 ms	1215.13 ms	-5.30 ms
`b95b8af`+dirty	1235.60 ms	1242.06 ms	6.46 ms
`dadc233`+dirty	1266.52 ms	1282.55 ms	16.03 ms
`1faf8e3`+dirty	1223.38 ms	1220.56 ms	-2.82 ms
`7bc4d75`+dirty	1222.13 ms	1216.39 ms	-5.74 ms
`1332acb`+dirty	1243.98 ms	1241.12 ms	-2.86 ms

App size

Revision	Plain	With Sentry	Diff
`5a22220`+dirty	2.92 MiB	3.48 MiB	575.81 KiB
`f06c879`+dirty	2.92 MiB	3.44 MiB	533.24 KiB
`c398f67`+dirty	2.92 MiB	3.60 MiB	701.89 KiB
`5bb8d5f`+dirty	2.92 MiB	3.48 MiB	575.85 KiB
`4cc5c27`+dirty	2.92 MiB	3.61 MiB	705.47 KiB
`b95b8af`+dirty	2.92 MiB	3.69 MiB	794.16 KiB
`dadc233`+dirty	2.92 MiB	3.40 MiB	492.53 KiB
`1faf8e3`+dirty	2.92 MiB	3.64 MiB	742.61 KiB
`7bc4d75`+dirty	2.92 MiB	3.66 MiB	757.15 KiB
`1332acb`+dirty	2.92 MiB	3.67 MiB	772.45 KiB

github-actions · 2025-01-03T14:36:53Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1224.76 ms	1227.84 ms	3.08 ms
Size	2.63 MiB	3.68 MiB	1.04 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5a22220`+dirty	1209.49 ms	1220.94 ms	11.45 ms
`f06c879`+dirty	1252.64 ms	1259.66 ms	7.02 ms
`c398f67`+dirty	1219.67 ms	1225.66 ms	5.99 ms
`5bb8d5f`+dirty	1235.47 ms	1237.39 ms	1.92 ms
`4cc5c27`+dirty	1211.45 ms	1214.60 ms	3.16 ms
`b95b8af`+dirty	1221.39 ms	1228.52 ms	7.13 ms
`dadc233`+dirty	1223.20 ms	1236.88 ms	13.68 ms
`1faf8e3`+dirty	1214.87 ms	1222.83 ms	7.97 ms
`7bc4d75`+dirty	1233.40 ms	1229.56 ms	-3.83 ms
`1332acb`+dirty	1230.53 ms	1234.54 ms	4.01 ms

App size

Revision	Plain	With Sentry	Diff
`5a22220`+dirty	2.36 MiB	2.92 MiB	570.21 KiB
`f06c879`+dirty	2.36 MiB	2.88 MiB	530.42 KiB
`c398f67`+dirty	2.36 MiB	3.04 MiB	696.27 KiB
`5bb8d5f`+dirty	2.36 MiB	2.92 MiB	570.22 KiB
`4cc5c27`+dirty	2.36 MiB	3.04 MiB	698.52 KiB
`b95b8af`+dirty	2.36 MiB	3.14 MiB	793.32 KiB
`dadc233`+dirty	2.36 MiB	2.84 MiB	486.85 KiB
`1faf8e3`+dirty	2.36 MiB	3.08 MiB	736.75 KiB
`7bc4d75`+dirty	2.36 MiB	3.10 MiB	752.58 KiB
`1332acb`+dirty	2.36 MiB	3.11 MiB	759.86 KiB

krystofwoldrich · 2025-01-09T16:42:20Z

This PR aims to tackle the CI failure with the minimum possible changes. As a next step we should consider upgrading our performance test apps (TestAppPlain/TestAppSentry) on the latest RN version.

Yes, definitely make sense to now just quickly fix this.

Long term it would be the best if we keep all the sample/perf/test apps on the latest version.

krystofwoldrich · 2025-01-09T17:01:35Z

The binary size bump should be revisited but I considered that this is needed at this point to unblock the CI and the release process.

I've check the size increase, it looks fine, since there were other changes it's increase in RN itself.

Bumps RN to 0.70.15 that includes the Boost fix

795a3c0

antonis changed the title ~~chore(ci): Bumps RN to 0.70.15 that includes the Boost fix~~ chore(ci): Fixes performance test failure due to Boost dependency URL unavailability Jan 3, 2025

antonis mentioned this pull request Jan 3, 2025

chore(deps): update CLI to v2.40.0 #4412

Merged

antonis changed the title ~~chore(ci): Fixes performance test failure due to Boost dependency URL unavailability~~ chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability Jan 3, 2025

antonis marked this pull request as ready for review January 3, 2025 11:28

antonis requested review from krystofwoldrich and lucas-zimerman as code owners January 3, 2025 11:28

antonis mentioned this pull request Jan 3, 2025

feat: Session Replay is GA #4384

Merged

8 tasks

Increase iOS binary size diff by 100KB

68f0bcf

romtsn approved these changes Jan 3, 2025

View reviewed changes

antonis merged commit 8fe7c9d into main Jan 3, 2025
72 checks passed

antonis deleted the antonis/boost-fix branch January 3, 2025 14:48

This was referenced Jan 8, 2025

ci: metrics (new, android) fails #4418

Closed

Upgrade performance test apps on the latest RN version #4426

Open

antonis mentioned this pull request Jan 28, 2025

chore(ci): Fixes iOS binary size diff failure #4489

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414

chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414

antonis commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025 •

edited

Loading

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Jan 9, 2025

krystofwoldrich commented Jan 9, 2025

chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414

chore(ci): Fixes performance tests failure due to Boost dependency URL unavailability #4414

Conversation

antonis commented Jan 3, 2025 • edited Loading

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Jan 3, 2025 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

github-actions bot commented Jan 3, 2025

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

krystofwoldrich commented Jan 9, 2025

krystofwoldrich commented Jan 9, 2025

antonis commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading

github-actions bot commented Jan 3, 2025 •

edited

Loading