Skip to content

Remove forked from test_transport and generalize capturing_server to be module level #4577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sl0thentr0py
Copy link
Member

@sl0thentr0py sl0thentr0py commented Jul 11, 2025

CapturingServer now has pytest.request level isolation and can be used just once per the module instead of on every test fork/run. As a result, test_transport now takes 14 seconds instead of almost 3 minutes.

BEFORE

 235 passed, 384 skipped in 173.78s (0:02:53)

AFTER

 235 passed, 384 skipped in 13.79s

part of #4538

@sl0thentr0py sl0thentr0py requested a review from a team as a code owner July 11, 2025 12:22
@sl0thentr0py sl0thentr0py force-pushed the neel/forked/transport branch from 6dddfe7 to b4977f6 Compare July 11, 2025 12:23
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.34%. Comparing base (1cba56a) to head (c9b3a79).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4577      +/-   ##
==========================================
- Coverage   80.71%   80.34%   -0.38%     
==========================================
  Files         156      156              
  Lines       16483    16483              
  Branches     2801     2801              
==========================================
- Hits        13304    13243      -61     
- Misses       2297     2362      +65     
+ Partials      882      878       -4     

see 8 files with indirect coverage changes

@sl0thentr0py sl0thentr0py force-pushed the neel/forked/transport branch from b4977f6 to c9b3a79 Compare July 11, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant