fix(sessions): clean up threading on kill+flush

This follows the precedent set in transport.flush, and helps me with my project
to assert thread hygeine in sentry test suite (related: DI-1008), but also makes
the system much more deterministic for everyone.

This will cause shutdown to be quite slow until #4561 goes in. So I'd reject
this if you reject that.

Author: bukzor

sentry_sdk/sessions.py

@@ -166,8 +166,9 @@ def __init__(
 
     def flush(self):
         # type: (...) -> None
-        pending_sessions = self.pending_sessions
-        self.pending_sessions = []
+        with self._thread_lock:
+            pending_sessions = self.pending_sessions
+            self.pending_sessions = []
 
         with self._aggregate_lock:
             pending_aggregates = self.pending_aggregates
@@ -191,6 +192,26 @@ def flush(self):
         if len(envelope.items) > 0:
             self.capture_func(envelope)
 
+        # hygiene: deterministically clean up any stopping thread
+        if not self._thread_stopping():
+            return
+        with self._thread_lock:
+            if not self._thread_stopping():
+                return
+            if self._thread:  # typing
+                self._thread.join()
+                self._thread = None
+                self._thread_for_pid = None
+
+    def _thread_stopping(self):
+        # type: (...) -> bool
+        return (
+            not self._running
+            and self._thread is not None
+            # we are the parent thread:
+            and self._thread_for_pid == os.getpid()
+        )
+
     def _ensure_running(self):
         # type: (...) -> None
         """