Skip to content

Commit a7b2d67

Browse files
authored
test(loguru): Remove hardcoded line number in test_just_log (#4552)
Use regex to check line number instead of hard coding it Fixes GH-4454 #4454 <!-- Describe your PR here --> Changed the loguru test_just_log test to use a regex for the log format instead of a hard-coded line number.
1 parent 7e4053a commit a7b2d67

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

tests/integrations/loguru/test_loguru.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
from unittest.mock import MagicMock, patch
2+
import re
23

34
import pytest
45
from loguru import logger
@@ -56,10 +57,10 @@ def test_just_log(
5657

5758
getattr(logger, level.name.lower())("test")
5859

59-
formatted_message = (
60-
" | "
61-
+ "{:9}".format(level.name.upper())
62-
+ "| tests.integrations.loguru.test_loguru:test_just_log:57 - test"
60+
expected_pattern = (
61+
r" \| "
62+
+ r"{:9}".format(level.name.upper())
63+
+ r"\| tests\.integrations\.loguru\.test_loguru:test_just_log:\d+ - test"
6364
)
6465

6566
if not created_event:
@@ -72,7 +73,7 @@ def test_just_log(
7273
(breadcrumb,) = breadcrumbs
7374
assert breadcrumb["level"] == expected_sentry_level
7475
assert breadcrumb["category"] == "tests.integrations.loguru.test_loguru"
75-
assert breadcrumb["message"][23:] == formatted_message
76+
assert re.fullmatch(expected_pattern, breadcrumb["message"][23:])
7677
else:
7778
assert not breadcrumbs
7879

@@ -85,7 +86,7 @@ def test_just_log(
8586
(event,) = events
8687
assert event["level"] == expected_sentry_level
8788
assert event["logger"] == "tests.integrations.loguru.test_loguru"
88-
assert event["logentry"]["message"][23:] == formatted_message
89+
assert re.fullmatch(expected_pattern, event["logentry"]["message"][23:])
8990

9091

9192
def test_breadcrumb_format(sentry_init, capture_events, uninstall_integration, request):

0 commit comments

Comments
 (0)