Skip to content

ref: Remove the framework tunnel hooks - #26001

Open
logaretm wants to merge 1 commit into
awad/runtime-tunnel-lambdafrom
awad/runtime-tunnel-drop-framework-hooks
Open

ref: Remove the framework tunnel hooks#26001
logaretm wants to merge 1 commit into
awad/runtime-tunnel-lambdafrom
awad/runtime-tunnel-drop-framework-hooks

Conversation

@logaretm

@logaretm logaretm commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

At this point, we handle the runtimes we support, so the previous framework-specific wiring is no longer needed.

This PR adjusts a couple of wiring for some safety around double inits in serverless environments, and cleans up most of the old code introduced in 11.10.

@logaretm
logaretm added this pull request to stack #26002 November 2, 2026 19:44
@github-actions

github-actions Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

Compared: 8d098a1 (PR test merge using develop at 9a20ed1)

Against: dd9903c (develop) · base run #64617

⚠️ Baseline mismatch: 24 develop commit(s) in the PR build are missing from the baseline. Their size changes also affect this comparison. Compare commits. Re-run once develop's baseline build for 9a20ed1 finishes.

Path Size % Change Change
@sentry/browser 30.39 kB - -
@sentry/browser - with treeshaking flags 28.54 kB - -
@sentry/browser - with treeshaking flags tracing without tracing 28.42 kB - -
@sentry/browser (incl. Tracing) 52.71 kB - -
@sentry/browser (incl. Tracing + Span Streaming) 52.72 kB - -
@sentry/browser (incl. Tracing, Profiling) 55.69 kB - -
@sentry/browser (incl. Tracing, Replay) 93.01 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 81.61 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 97.76 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 110.75 kB - -
@sentry/browser (incl. Feedback) 47.98 kB - -
@sentry/browser (incl. sendFeedback) 35.5 kB - -
@sentry/browser (incl. FeedbackAsync) 40.6 kB - -
@sentry/browser (incl. Metrics) 31.43 kB - -
@sentry/browser (incl. Logs) 31.72 kB - -
@sentry/browser (incl. Metrics & Logs) 32.44 kB - -
@sentry/react 32.28 kB - -
@sentry/react (incl. Tracing) 55.08 kB - -
@sentry/vue 38.66 kB - -
@sentry/vue (incl. Tracing) 55.73 kB - -
@sentry/svelte 30.42 kB - -
@sentry/remix (Remix 3 client bundle) 57.79 kB - -
CDN Bundle 32.18 kB - -
CDN Bundle (incl. Tracing) 53.23 kB - -
CDN Bundle (incl. Logs, Metrics) 34.46 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 55.17 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 75.87 kB - -
CDN Bundle (incl. Tracing, Replay) 91.45 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 93.38 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 97.55 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 99.55 kB - -
CDN Bundle - uncompressed 94.64 kB - -
CDN Bundle (incl. Tracing) - uncompressed 157.6 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 101.11 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 163.34 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 232.68 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 279.29 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 285.01 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 293 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 298.71 kB - -
@sentry/nextjs (client) 58.03 kB - -
@sentry/sveltekit (client) 53.23 kB - -
@sentry/core/server 44.47 kB +0.52% +230 B 🔺
@sentry/core/browser 13.93 kB - -
@sentry/node 155.98 kB +0.19% +285 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 82.22 kB +0.01% +2 B 🔺
@sentry/node - without tracing 97.1 kB +0.3% +283 B 🔺
@sentry/node - without channel injection 136.3 kB +0.21% +277 B 🔺
@sentry/aws-serverless 105.36 kB +0.33% +343 B 🔺
@sentry/cloudflare (withSentry) - minified 202.02 kB +0.69% +1.38 kB 🔺
@sentry/cloudflare (withSentry) 501.94 kB +0.59% +2.94 kB 🔺
@sentry/nextjs/cloudflare (withSentry) - minified 222.55 kB +0.63% +1.38 kB 🔺

View base workflow run

@github-actions

github-actions Bot commented Nov 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Optional E2E tests

Some optional checks were not successful. They do not block the merge. 2 not successful, 10 successful. See the run.

Check Status
❌ CI: Optional E2E Tests / E2E nuxt-5 (tunnel-dev) Test (optional) Failing after 2m Details
❌ CI: Optional E2E Tests / E2E nuxt-5 Test (optional) Failing after 2m Details
Successful checks
Check Status
✅ CI: Optional E2E Tests / E2E astro-7-static Test (optional) Successful in 48s Details
✅ CI: Optional E2E Tests / E2E astro-7 Test (optional) Successful in 55s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-sourcemaps Test (optional) Successful in 20s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (static / nuxt generate) Test (optional) Successful in 34s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react-cloudflare Test (optional) Successful in 33s Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps Test (optional) Successful in 38s Details
✅ CI: Optional E2E Tests / E2E tanstackstart-react (latest) Test (optional) Successful in 1m Details
✅ CI: Optional E2E Tests / E2E nuxt-5-sourcemaps (client source maps kept) Test (optional) Successful in 23s Details
✅ CI: Optional E2E Tests / E2E react-router-7-framework-instrumentation Test (optional) Successful in 2m Details
✅ CI: Optional E2E Tests / E2E solidstart-2 Test (optional) Successful in 43s Details

@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch 2 times, most recently from 80937ea to 05739c4 Compare November 2, 2026 21:29
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch 2 times, most recently from 8290699 to 5070a1e Compare November 3, 2026 04:10
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch 2 times, most recently from 2df929e to 37ff5cc Compare November 3, 2026 04:28
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch from 37ff5cc to d4ee2c6 Compare November 3, 2026 04:42
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch from d4ee2c6 to df4b1de Compare November 3, 2026 04:45
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch 4 times, most recently from f0a9f77 to e9a696a Compare November 3, 2026 05:17
@logaretm
logaretm marked this pull request as ready for review November 3, 2026 05:19
@logaretm
logaretm requested review from a team as code owners November 3, 2026 05:19
@logaretm
logaretm requested review from nicohrubec and s1gr1d and removed request for a team November 3, 2026 05:19
@logaretm
logaretm requested review from Lms24, isaacs, msonnb and mydea and removed request for a team November 3, 2026 05:19
@logaretm
ref: Remove the framework tunnel hooks
93418ff 
The runtimes answer managed tunnel requests before any framework sees them, so the per-framework hooks in
Astro, Nitro, Nuxt, React Router, Remix, SolidStart, SvelteKit and TanStack Start go. The frameworks only set
the tunnel's base path. Astro now initializes the server SDK from the server entry in builds, which the late
init in its middleware used to cover.
@logaretm
logaretm force-pushed the awad/runtime-tunnel-drop-framework-hooks branch from e9a696a to 93418ff Compare November 3, 2026 05:37

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicohrubec nicohrubec Awaiting requested review from nicohrubec nicohrubec is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@s1gr1d s1gr1d Awaiting requested review from s1gr1d s1gr1d is a code owner automatically assigned from getsentry/team-javascript-sdks-framework
@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@msonnb msonnb Awaiting requested review from msonnb msonnb is a code owner automatically assigned from getsentry/team-javascript-sdks-browser
@isaacs isaacs Awaiting requested review from isaacs isaacs is a code owner automatically assigned from getsentry/team-javascript-sdks-server
@mydea mydea Awaiting requested review from mydea mydea is a code owner automatically assigned from getsentry/team-javascript-sdks-server

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@logaretm