ref(nextjs): Improve app router routing instrumentation accuracy #13695
+352
−229
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the Next.js routing instrumentation by patching the Next.js router and instrumenting window popstates.
A few details on this PR that might explain weird-looking logic:
router.back
/router.forward
and thepopstate
event to emit a properly named transaction, becauserouter.back
androuter.forward
aren't passed any useful strings we could use as txn names.router.back
/router.forward
calls and thepopstate
event, we temporarily give the navigation span an invalid name that we use as an indicator to drop if one may leak through.