ref(profiling) use cleanup instead of destructor #13661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Sep 10, 2024
JonasBa
force-pushed
the
jb/profiling/exit-segfault
branch
from
561faff
to
b9a3c02
Compare
AbhiPrasad
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Fixes #13661 in the GH description points to this PR, we need to change it to the issue.
|
Also Jonas can I try running codecov ai bot on this PR? I'm very curious what it thinks of the c++ |
|
@AbhiPrasad there is no coverage in cpp so I think its not gonna be happy, but feel free to run it yes :) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think what is happening is that by the time our close handler is called, the handler had already been deleted, which causes a use after free error. I also updated the code to check for is_closing which is what that underlying libuv method actually asserts on.
Fixes #13661