Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Unflake remix E2E test #13534

Merged
merged 2 commits into from
Aug 30, 2024
Merged

test: Unflake remix E2E test #13534

merged 2 commits into from
Aug 30, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Aug 30, 2024

@mydea mydea self-assigned this Aug 30, 2024
lforst
lforst approved these changes Aug 30, 2024
View reviewed changes
Copy link
Member

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we could be even more safe and put the waitForTransaction all the way to the top of the test.

@mydea mydea merged commit eacf56b into develop Aug 30, 2024
99 checks passed
@mydea mydea deleted the fn/unflake branch August 30, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lforst lforst lforst approved these changes

@onurtemizkan onurtemizkan onurtemizkan approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mydea @onurtemizkan @lforst @Lms24